Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(ci): Explain how to resolve duplicate dependency warnings #5017

Merged
merged 4 commits into from
Sep 1, 2022
Merged

doc(ci): Explain how to resolve duplicate dependency warnings #5017

merged 4 commits into from
Sep 1, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

We want to document how CI works and how to fix common errors.

Solution

Explain how to fix duplicate dependency warnings.

Review

Anyone can review this PR.

Reviewer Checklist

  • Docs make sense

@teor2345 teor2345 added A-docs Area: Documentation A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement P-Medium ⚡ labels Aug 31, 2022
@teor2345 teor2345 self-assigned this Aug 31, 2022
@teor2345 teor2345 requested a review from a team as a code owner August 31, 2022 05:50
@teor2345 teor2345 requested review from upbqdn and removed request for a team August 31, 2022 05:50
upbqdn
upbqdn previously approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@upbqdn upbqdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oxarbitrage
oxarbitrage reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The procedure in point 2 does not looks very clear to me (for example what an immediate dependency means ? maybe an example with a foo dependency will help?).
Also, i think it will help to add a paragraph on why this warnings can happen and when.

@teor2345
Copy link
Contributor Author

The procedure in point 2 does not looks very clear to me (for example what an immediate dependency means ? maybe an example with a foo dependency will help?).

I linked to some PRs that show different kinds of dependency fixes.

Also, i think it will help to add a paragraph on why this warnings can happen and when.

Done!

This was referenced Sep 1, 2022
Closed
Closed
mergify bot added a commit that referenced this pull request Sep 1, 2022
@mergify
Merge of #5017
4bc824d
@mergify mergify bot mentioned this pull request Sep 1, 2022
Closed
@mergify mergify bot merged commit edd32a7 into main Sep 1, 2022
@mergify mergify bot deleted the ci-doc-dup-dependencies branch September 1, 2022 19:13
@teor2345 teor2345 mentioned this pull request Sep 19, 2022
Merged
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn left review comments

@oxarbitrage oxarbitrage oxarbitrage left review comments

@gustavovalverde gustavovalverde gustavovalverde approved these changes

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-docs Area: Documentation C-enhancement Category: This is an improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teor2345 @upbqdn @gustavovalverde @oxarbitrage