Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(release): add versioning and releases information #4917

Merged
merged 10 commits into from
Sep 15, 2022
Merged

Conversation

gustavovalverde
Copy link
Member

@gustavovalverde gustavovalverde commented Aug 17, 2022

Motivation

Our release process and criteria needed to be updated.

Review

This is a draft PR, but it needs review in this stage before continue adding more sections or details.

Reviewer Checklist

  • Sections are the ones required in this document
  • The stated arguments can be complied by the Zebra team
  • None of the arguments goes against our Tier Policies

Follow Up Work

Get feedback to make the needed changes

Review some Angular documents that might be helpful to adapt:

Fixes #4778

@gustavovalverde gustavovalverde added A-docs Area: Documentation C-enhancement Category: This is an improvement P-Medium ⚡ I-usability Zebra is hard to understand or use labels Aug 17, 2022
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this release process update. It looks good, it just needs a few tweaks to bring it into line with previous team decisions.

In general, we prefer to use Rust ecosystem conventions, because Zebra is a Rust project. What's here is fine for now, but we might not want to use Angular as an example in future. We might also want to discuss scope before we create the next large document, to avoid wasted effort.

It seems like this PR duplicates some explanations from the release PR template. Can you please remove any duplicate or conflicting details from the release PR template?
For example, we don't need to explain semver in both places.

Is this PR meant to close ticket #4778?
We'll need to update this README section to close that ticket:
https://github.com/ZcashFoundation/zebra#beta-releases

But since this PR is already big, we might want to do that in a separate PR.

Co-authored-by: teor <teor@riseup.net>
@gustavovalverde gustavovalverde marked this pull request as ready for review September 14, 2022 20:59
@gustavovalverde gustavovalverde requested a review from a team as a code owner September 14, 2022 20:59
@gustavovalverde gustavovalverde requested review from teor2345 and removed request for a team September 14, 2022 20:59
teor2345
teor2345 previously approved these changes Sep 14, 2022
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for all these edits!

I made some suggestions, but none of them are blocking.
(And I'm happy for anyone else to re-approve this PR.)

Co-authored-by: teor <teor@riseup.net>
@gustavovalverde
Copy link
Member Author

@teor2345 suggestions applied as-is

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this, and thanks for working though all my suggestions!

mergify bot added a commit that referenced this pull request Sep 15, 2022
@mergify mergify bot merged commit 085367f into main Sep 15, 2022
@mergify mergify bot deleted the feat-doc-ci branch September 15, 2022 02:17
Copy link
Contributor

@mpguerra mpguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this has already merged I just wanted to find out what we had decided on for our release process and I found a few nit-picky things as I was reading :)


**NOTE**: <br />
As Zebra is in a `pre-release` state (is unstable and might not satisfy the intended compatibility requirements as denoted by its associated normal version).
The pre-release version is denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an example could be nice here

@@ -0,0 +1,118 @@
# Zebra versioning and releases

This document contains the practices that we follow to provide you with a leading-edge application, balanced and with stability.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like theres an extra "and" should this be: "provide you with a leading-edge application, balanced with stability." ?

| Level of change | Details |
|:--- |:--- |
| Major release | Contains significant new features, and commonly correspond to network upgrades; some technical assistance may be needed during the update. When updating to a major release, you may need to follow the specific upgrade instructions provided in the release notes. |
| Minor release | Contains new smaller features. Minor releases are should be fully backward-compatible. No technical assistance is expected during update. If you want to use the new features in a minor release, you might need to follow the instructions in the release notes. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra "are"; should read: "Minor releases should be fully backward-compatible." instead


<a id="previews"></a>

### Preview releases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this answers my comment above about giving an example of pre-release versioning, maybe we can link to here from there instead. e.g for an example see "Preview releases"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace old release criteria with stable release candidate criteria in docs
3 participants