Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): add beta rust to CI #4637

Merged
merged 5 commits into from
Jun 22, 2022
Merged

fix(build): add beta rust to CI #4637

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f38a15c
fix(build): add `beta` rust to CI
gustavovalverde Jun 17, 2022
d79e10f
fix(ci): remove macos-latest with beta Rust combination
gustavovalverde Jun 20, 2022
def9745
Merge branch 'main' into add-beta-rust
mergify[bot] Jun 21, 2022
30f5708
Remove redundant fake activation heights OS job
teor2345 Jun 22, 2022
913313f
Merge branch 'main' into add-beta-rust
mergify[bot] Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 8 additions & 42 deletions .github/workflows/continous-integration-os.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,14 @@ jobs:
matrix:
# TODO: Windows was removed for now, see https://github.com/ZcashFoundation/zebra/issues/3801
os: [ubuntu-latest, macos-latest]
rust: [stable]
rust: [stable, beta]
# We're excluding macOS for the following reasons:
# - the concurrent macOS runner limit is much lower than the Linux limit
# - macOS is slower than Linux, and shouldn't have a build or test difference with Linux
# - macOS is a second-tier Zebra support platform
exclude:
- os: macos-latest
rust: beta

steps:
- uses: actions/checkout@v3.0.2
Expand Down Expand Up @@ -146,47 +153,6 @@ jobs:
# Note: this only runs the zebrad acceptance tests, because re-running all the test binaries is slow on Windows
args: --verbose --package zebrad --test acceptance -- --nocapture --include-ignored sync_large_checkpoints_

test-fake-activation-heights:
name: Test ${{ matrix.rust }} zebra-state with fake activation heights on ubuntu-latest
timeout-minutes: 60
runs-on: ubuntu-latest
strategy:
matrix:
rust: [stable]

steps:
- uses: actions/checkout@v3.0.2
with:
persist-credentials: false

- uses: actions-rs/toolchain@v1
with:
toolchain: ${{ matrix.rust }}
profile: minimal
override: true

- uses: Swatinem/rust-cache@v1

- name: cargo fetch
uses: actions-rs/cargo@v1.0.3
with:
command: fetch

# This test changes zebra-chain's activation heights,
# which can recompile all the Zebra crates,
# so we want its build products to be cached separately.
#
# Also, we don't want to accidentally use the fake heights in other tests.
- name: Run tests with fake activation heights
uses: actions-rs/cargo@v1.0.3
env:
TEST_FAKE_ACTIVATION_HEIGHTS: ''
with:
command: test
# Note: this only runs the zebra-state crate tests,
# because re-running all the test binaries can be slow
args: --verbose --package zebra-state --lib -- --nocapture --include-ignored with_fake_activation_heights

build-chain-no-features:
name: Build ${{ matrix.rust }} zebra-chain w/o features on ubuntu-latest
timeout-minutes: 60
Expand Down