Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): use debian for faster mounting and bump readiness time #4276

Merged
merged 1 commit into from
May 3, 2022
Merged

fix(ci): use debian for faster mounting and bump readiness time #4276

merged 1 commit into from
May 3, 2022

Conversation

gustavovalverde
Copy link
Member

Motivation

After merging #4252 deployment are failing as it had some minor issues which caused the disk not to be mounted and the full sync deployment had a typo.

Solution

  • Fix typo in full sync, and bump sleep times to allow disk to get mounted.

Review

Anyone from @ZcashFoundation/devops-reviewers

Reviewer Checklist

  • This one is urgent 🚨

@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd labels May 3, 2022
@gustavovalverde gustavovalverde self-assigned this May 3, 2022
@gustavovalverde gustavovalverde requested a review from a team as a code owner May 3, 2022 10:17
@gustavovalverde gustavovalverde requested review from conradoplg and removed request for a team May 3, 2022 10:17
@gustavovalverde gustavovalverde changed the title fix(ci): use debian for faster mounting, and increase timeout fix(ci): use debian for faster mounting and bump readiness time May 3, 2022
@gustavovalverde
Copy link
Member Author

I'm admin merging as the team won't be available in a few hours, and test deployments on main won't continue until this fixes are applied.

@gustavovalverde gustavovalverde merged commit 6331722 into main May 3, 2022
@gustavovalverde gustavovalverde deleted the fix-deploy-issues branch May 3, 2022 10:49
dconnolly
dconnolly reviewed May 3, 2022
View reviewed changes
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly left review comments

@conradoplg conradoplg Awaiting requested review from conradoplg conradoplg is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@gustavovalverde gustavovalverde

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gustavovalverde @dconnolly