-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add sending_transactions_using_lightwalletd
test to CI
#4267
Conversation
This is a workaround for an issue related to disk partitioning, caused by a GCP service called Konlet, while mounting the cached disks to the VM and then to the container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good so far, I just have a few questions.
Edit: question resolved by PR #4332
@jvff @gustavovalverde it seems like there is a bug in the
This state path looks suspicious:
It would be helpful if https://github.com/ZcashFoundation/zebra/runs/6312788960?check_suite_focus=true#step:8:217 |
That was a workaround for an issue that has been fixed.
I opened PR #4332 to fix this. |
Co-authored-by: teor <teor@riseup.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are the conditions we want
|
I'm re-running those jobs now. |
Still failing with:
https://github.com/ZcashFoundation/zebra/runs/6314502890?check_suite_focus=true#step:8:292 |
@Mergifyio update |
✅ Branch has been successfully updated |
Was also part of a workaround for an issue that has been fixed.
Co-authored-by: teor <teor@riseup.net>
Some versions print `Waiting for block`, and some versions print `Ingestor waiting for block`.
I'll restart |
@Mergifyio update |
✅ Branch has been successfully updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all appears to be working correctly
{"app":"lightwalletd","level":"info","msg":"Adding new mempool txid 0f0e4c4978d9446bc9b173612c71c705ecf7dd2f6e7432f6b04697d6b2be9a04 sending to 0 clients","time":"2022-05-06T04:13:04Z"}
https://github.com/ZcashFoundation/zebra/runs/6317043136?check_suite_focus=true#step:8:728
test sending_transactions_using_lightwalletd ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 37 filtered out; finished in 2241.01s
https://github.com/ZcashFoundation/zebra/runs/6317043136?check_suite_focus=true#step:8:819
May 06 04:13:04.654 INFO {net="Main"}: zebrad::components::mempool::gossip: sending mempool transaction broadcast request=AdvertiseTransactionIds({Legacy(transaction::Hash("0f0e4c4978d9446bc9b173612c71c705ecf7dd2f6e7432f6b04697d6b2be9a04"))})
https://github.com/ZcashFoundation/zebra/runs/6317043136?check_suite_focus=true#step:8:812
Motivation
We want to add all completed
lightwalletd
integration tests to CI, to confirm we're not introducing bugs to the RPC endpoints or any other implementation related tolightwalletd
Fixes #4168
Fixes: #4305
Designs
test.yml
andtest-full-sync.yml
Solution
sending_transactions_using_lightwalletd
test to CIsending_transactions_using_lightwalletd
toentrypoint.sh
for easier executionReview
Anyone from the DevOps team can review this
Reviewer Checklist
Follow Up Work
Simplify this job with the refactor being done for reusable workflows