Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): create a full sync disk to add the cached state inside #4266

Merged
merged 1 commit into from
May 3, 2022

Conversation

gustavovalverde
Copy link
Member

Motivation

Since the first implementation, the resulting disk image after a full sync is not containing the cached state, as it has been an empty disk without the /zebrad-cache dir

Fixes: #4265

Solution

  • Mount an extra disk to the full sync test where we're going to save the state
  • Standardize this with the checkpoint test

Review

Anyone from @ZcashFoundation/devops-reviewers can review this

Follow Up Work

@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-infrastructure Area: Infrastructure changes A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd labels May 2, 2022
@gustavovalverde gustavovalverde self-assigned this May 2, 2022
@gustavovalverde gustavovalverde requested a review from a team as a code owner May 2, 2022 19:39
@gustavovalverde gustavovalverde requested review from conradoplg and removed request for a team May 2, 2022 19:39
@gustavovalverde gustavovalverde changed the title fix(ci): create a full sync disk with cached state inside fix(ci): create a full sync disk to add the cached state inside May 2, 2022
@dconnolly
Copy link
Contributor

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, but I'd like @gustavovalverde to be around to test it when it merges.

So I'll open a comment, which you can resolve when you have time to merge and test it.

@teor2345
Copy link
Contributor

teor2345 commented May 3, 2022

Build images failed due to #4234:

Error: buildx failed with: error: failed to solve: failed to fetch oauth token: unexpected status: 401 Unauthorized

https://github.com/ZcashFoundation/zebra/runs/6264577336?check_suite_focus=true#step:9:2180

@gustavovalverde
Copy link
Member Author

Manually merging

@gustavovalverde gustavovalverde merged commit fe97e14 into main May 3, 2022
@gustavovalverde gustavovalverde deleted the fix-full-state branch May 3, 2022 01:28
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-infrastructure Area: Infrastructure changes C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: full sync cached state is not being written to disk
3 participants