Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chain): make FromHex consistent with ToHex for tx/block hashes #3893

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

conradoplg
Copy link
Collaborator

Motivation

FromHex wasn't reversing the bytes like ToHex does for transaction and block hashes. (See here for some background on this terrible decision of reversing in the first place 🤣 )

Specifications

Designs

Solution

Fix it, add tests

Review

Detected while working on #3145, also discovered in #3891. It's not currently blocking those, but will soon.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

@conradoplg conradoplg requested a review from a team as a code owner March 17, 2022 13:22
@conradoplg conradoplg requested review from teor2345 and removed request for a team March 17, 2022 13:22
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@conradoplg
Copy link
Collaborator Author

lightwalletd test failed with

Error: 
   0: stdout of command did not contain any matches for the given regex

Location:
   /app/zebra-test/src/command.rs:330

Command:
   "lightwalletd" "--zcash-conf-path" "/tmp/zebrad_testsTk0gns/lightwalletd-zcash.conf" "--data-dir" "/tmp/zebrad_testsTk0gns" "--log-file" "/dev/stdout" "--grpc-bind-addr" "127.0.0.1:0" "--http-bind-addr" "127.0.0.1:0" "--no-tls-very-insecure"

Exit Status:
   command terminated unsuccessfully by signal 9

Match Regex:
   "Ingestor adding block to cache"

Command:
   "/app/target/release/zebrad" "-c" "/tmp/zebrad_testshcRZTZ/zebrad.toml" "start"

Exit Status:
   command terminated unsuccessfully by signal 9

Stderr:
   [sentry] initialized disabled sentry client due to disabled or invalid DSN

Works on my machine though, so I'm retrying it

mergify bot added a commit that referenced this pull request Mar 17, 2022
@mergify mergify bot merged commit b9640fb into main Mar 17, 2022
@mergify mergify bot deleted the consistent-hex branch March 17, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants