fix(chain): make FromHex consistent with ToHex for tx/block hashes #3893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
FromHex
wasn't reversing the bytes likeToHex
does for transaction and block hashes. (See here for some background on this terrible decision of reversing in the first place 🤣 )Specifications
Designs
Solution
Fix it, add tests
Review
Detected while working on #3145, also discovered in #3891. It's not currently blocking those, but will soon.
Reviewer Checklist
Follow Up Work