-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test/lightwalletd): add an alternative log to the final integration test check #3758
Conversation
Sometimes lightwalletd goes straight to "Another refresh in progress", without logging "Mempool refresh error" first.
The Windows tracing conflict test might have failed due to PR #3755. |
This has been timing out on a few PRs, i thought it was just happening on the Docker build, but in this PR it happened in all the tests (except macOS) This makes most test to hang indefinitely cc: @conradoplg EDIT: Nevermind, I thought #3755 was merged |
@Mergifyio update |
✅ Branch has been successfully updated |
Codecov Report
@@ Coverage Diff @@
## main #3758 +/- ##
==========================================
+ Coverage 78.86% 78.99% +0.13%
==========================================
Files 288 288
Lines 33299 33299
==========================================
+ Hits 26260 26306 +46
+ Misses 7039 6993 -46 |
|
Motivation
Sometimes lightwalletd goes straight to logging "Another refresh in progress", without logging "Mempool refresh error" first.
Review
This is a high-priority fix, but the test sometimes succeeds.
Reviewer Checklist