Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test/lightwalletd): add an alternative log to the final integration test check #3758

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 7, 2022

Motivation

Sometimes lightwalletd goes straight to logging "Another refresh in progress", without logging "Mempool refresh error" first.

Review

This is a high-priority fix, but the test sometimes succeeds.

Reviewer Checklist

  • Integration test passes

Sometimes lightwalletd goes straight to "Another refresh in progress",
without logging "Mempool refresh error" first.
@teor2345 teor2345 added C-bug Category: This is a bug P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces labels Mar 7, 2022
@teor2345 teor2345 self-assigned this Mar 7, 2022
@teor2345 teor2345 requested a review from a team as a code owner March 7, 2022 02:00
@teor2345 teor2345 requested review from upbqdn and removed request for a team March 7, 2022 02:00
@teor2345 teor2345 mentioned this pull request Mar 7, 2022
@teor2345
Copy link
Contributor Author

teor2345 commented Mar 7, 2022

The Windows tracing conflict test might have failed due to PR #3755.

@gustavovalverde
Copy link
Member

gustavovalverde commented Mar 7, 2022

This has been timing out on a few PRs, i thought it was just happening on the Docker build, but in this PR it happened in all the tests (except macOS) test tracing_endpoint has been running for over 60 seconds. There's something odd with tracing_endpoint

This makes most test to hang indefinitely cc: @conradoplg

EDIT: Nevermind, I thought #3755 was merged

@teor2345
Copy link
Contributor Author

teor2345 commented Mar 7, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2022

update

✅ Branch has been successfully updated

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #3758 (203bfdc) into main (d718f1d) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3758      +/-   ##
==========================================
+ Coverage   78.86%   78.99%   +0.13%     
==========================================
  Files         288      288              
  Lines       33299    33299              
==========================================
+ Hits        26260    26306      +46     
+ Misses       7039     6993      -46     

@teor2345
Copy link
Contributor Author

teor2345 commented Mar 7, 2022

Quota 'PD_EXTREME_TOTAL_PROVISIONED_IOPS' exceeded. Limit: 720000.0 in region us-central1.

mergify bot added a commit that referenced this pull request Mar 8, 2022
mergify bot added a commit that referenced this pull request Mar 8, 2022
mergify bot added a commit that referenced this pull request Mar 8, 2022
@mergify mergify bot merged commit 886a4f5 into main Mar 8, 2022
@mergify mergify bot deleted the fix-ligtwalletd-test-log branch March 8, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces C-bug Category: This is a bug C-testing Category: These are tests I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants