feat(build): add arm64 support with cross-compilation #3659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package is not available for this platform
teor2345
suggested changes
Feb 27, 2022
There was a problem hiding this comment.
This seems important, because we have at least two engineers using machines with ARM processors. But this also adds another supported platform to CI.
Did you want to check with the whole team before we merge this?
Last time we talked about our supported platforms, the next step was a creating a draft list of platforms and support levels.
(I'm marking this as "Request Changes", so we don't accidentally merge it.)
teor2345
approved these changes
Feb 28, 2022
gustavovalverde
added a commit
that referenced
this pull request
Mar 1, 2022
This reverts commit 291e00c.
dconnolly
pushed a commit
that referenced
this pull request
Mar 2, 2022
* feat(build): add arrm64 support * fix(build): do not install google-compute-engine in arm64 This package is not available for this platform * fix(build): do not build arm64 for tests
dconnolly
pushed a commit
that referenced
this pull request
Mar 2, 2022
This reverts commit 291e00c.
mergify bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
* add(actions): lightwalletd continous integrations * refactor(actions): build lightwalletd and reuse it in zebra - Download lightwalletd source code - Create a new Dockerfile for lightwalletd - Use lightwalletd binary in Zebra's image - Create a specific step to build/update lightwalletd - Add lightwalletd integration test to the test suite - Remove lightwalletd.yml, as it was harder to control * fix(build): remove extra port being exposed * fix(lightwalletd): test should be after `--` in cargo test * revert(lint): do not lint external code as it can be confusing * fix(test): lightwalletd_integration test is not ignored * docs(docker): clarify the addition of unused args * refactor(docker): organize Dockerfiles and remove unused Fixes: #3344 * fix(actions): activate workflows on correct path changes * test * revert previous commit * feat(build): add arm64 support with cross-compilation (#3659) * feat(build): add arrm64 support * fix(build): do not install google-compute-engine in arm64 This package is not available for this platform * fix(build): do not build arm64 for tests * fix(changes): reduce changelog * Revert "feat(build): add arm64 support with cross-compilation (#3659)" This reverts commit 291e00c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To run dockerized containers in M1 and other arm64 processors, we need to cross-compile the Docker image for this platforms. This makes it very hard to test locally, as all builds must be done remotely, or pushing to confirm on GHA.
Solution
Review
@dconnolly can review this