merge-queue: embarking main (c24ea1f) and #3643 together #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mempool is only activated once, so we must check for that log first. After mempool activation, the stop regex is logged at least once. (It might be logged before as well, but we can't rely on that.) When checking that the mempool didn't activate, wait for the `zebrad` command to exit, then check the entire log.
Codecov Report
@@ Coverage Diff @@
## main #3656 +/- ##
==========================================
+ Coverage 80.03% 80.04% +0.01%
==========================================
Files 284 284
Lines 32740 32740
==========================================
+ Hits 26202 26206 +4
+ Misses 6538 6534 -4 |
|
The pull request #3643 is mergeable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 This combination of pull requests has been checked successfully 🎉
Branch main (c24ea1f) and #3643 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #3643.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
urgentfor merge:check-success=Clippycheck-neutral=Clippycheck-skipped=Clippycheck-success=Rustfmtcheck-neutral=Rustfmtcheck-skipped=Rustfmtcheck-success=Test with fake activation heightscheck-neutral=Test with fake activation heightscheck-skipped=Test with fake activation heightscheck-success=Test full validation sync from cached statecheck-neutral=Test full validation sync from cached statecheck-skipped=Test full validation sync from cached statecheck-success=Test stable on macOS-latestcheck-neutral=Test stable on macOS-latestcheck-skipped=Test stable on macOS-latestcheck-success=Test stable on ubuntu-latestcheck-neutral=Test stable on ubuntu-latestcheck-skipped=Test stable on ubuntu-latestcheck-success=Test stable on windows-latestcheck-neutral=Test stable on windows-latestcheck-skipped=Test stable on windows-latestcheck-success=Test allcheck-neutral=Test allcheck-skipped=Test all#approved-reviews-by>=1[🛡 GitHub branch protection]#changes-requested-reviews-by=0[🛡 GitHub branch protection]#review-threads-unresolved=0[🛡 GitHub branch protection]check-success=Test allcheck-success=Test with fake activation heightscheck-success=Test full validation sync from cached statecheck-success=Test stable zebra-state with fake activation heights on ubuntu-latestcheck-success=Test stable on ubuntu-latestcheck-success=Test stable on macOS-latestcheck-success=Test stable on windows-latestcheck-success=Coverage nightlycheck-success=Clippycheck-success=RustfmtMore informations about Mergify merge queue can be found in the documentation.
Mergify commands
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the queue rulesAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com