-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chain Tip Estimate Test: Log chain progress while Zebra is syncing #3495
Conversation
7dce780
to
2e70b4f
Compare
Codecov Report
@@ Coverage Diff @@
## main #3495 +/- ##
==========================================
+ Coverage 78.34% 78.65% +0.31%
==========================================
Files 267 274 +7
Lines 31526 32500 +974
==========================================
+ Hits 24698 25562 +864
- Misses 6828 6938 +110 |
Haven't reviewed the code but I tested it and already love it
|
It's even more fun on my local testnet sync, where the estimate each minute jumps by 2% 🎉 |
dbfaf34
to
9a5b634
Compare
2e70b4f
to
b213680
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! This is very useful :D
This helps test if the chain tip estimate is accurate, and helps diagnose problems during full sync tests.
b213680
to
b5e0670
Compare
Motivation
This PR helps test if the chain tip estimate is accurate when it's used in
zebrad
. It will help diagnose problems during full sync tests.On PR Estimate network chain tip height based on local node time and current best tip #3492, Janito asked:
Solution
I added a very simple chain tip progress log to Zebra.
This helped me answer the questions above:
lightwalletd
.ChainTip
API is very easy to use. (The internals are much less important, because we don't have any plans to use them directly, or change them.)This PR contains diagnostics for:
It implements part of the
zebrad
side of:zebrad
acceptance test that does a full sync to tip #3493Review
@jvff can review this PR.
It depends on PR #3492.
Reviewer Checklist
Follow Up Work