Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump futures crates to 0.3.19 #3276

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Bump futures crates to 0.3.19 #3276

merged 3 commits into from
Dec 21, 2021

Conversation

conradoplg
Copy link
Collaborator

Motivation

Some futures crates must be merged together, so this PR combines #3264 #3266 #3267

Specifications

Designs

Solution

Combine #3264 #3266 #3267

Review

I already reviewed the updates themselves, the reviewer just need to check if this PR truly combines all of #3264 #3266 #3267

Anyone can review this, it's not particularly urgent.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

@teor2345
Copy link
Contributor

Google Cloud failed due to bug #3239, I'll restart that job.

@teor2345 teor2345 enabled auto-merge (squash) December 21, 2021 22:43
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, weird how these crate versions got out of sync though.

Hopefully cargo deny can help avoid that in future updates.

@teor2345 teor2345 merged commit 074011e into main Dec 21, 2021
@teor2345 teor2345 deleted the bump-futures-0.3.19 branch December 21, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants