Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug-level Zebra network message tracing #3170

Merged
merged 4 commits into from
Dec 9, 2021
Merged

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Dec 8, 2021

Motivation

As part of #3136, #2726, and #2156, we need to trace Zebra network messages to and from peers.

This PR does not close any tickets.

Solution

Add debug-level tracing for:

  • Zebra requests to peers, and peer responses
  • Peer requests to Zebra, and Zebra responses

Review

Anyone can review this low-priority PR, but maybe @oxarbitrage has some time to review it?

Reviewer Checklist

  • Code produces useful diagnostics

Follow Up Work

@teor2345 teor2345 added C-enhancement Category: This is an improvement P-Low A-network Area: Network protocol updates or fixes A-diagnostics Area: Diagnosing issues or monitoring performance labels Dec 8, 2021
@teor2345 teor2345 requested a review from oxarbitrage December 8, 2021 03:57
@teor2345 teor2345 self-assigned this Dec 8, 2021
oxarbitrage
oxarbitrage previously approved these changes Dec 8, 2021
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor spacing issues but they are not important, feel free to discard them.

Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
@teor2345 teor2345 merged commit c55753d into main Dec 9, 2021
@teor2345 teor2345 deleted the debug-network-messages branch December 9, 2021 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants