Use broadcast::Receiver::recv instead of next
#2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
previously approved these changes
Oct 28, 2021
There was a problem hiding this comment.
broadcast::Receiver::recv exists in tokio 0.3.7:
https://docs.rs/tokio/0.3.7/tokio/sync/broadcast/struct.Receiver.html#method.recv
So we can merge this low-risk PR before the beta release if you want.
On newer versions of Tokio the `Receiver` doesn't implement `Stream`.
9da067d to
ce54247
Compare
mpguerra
approved these changes
Oct 29, 2021
|
I just moved this to draft since from the description it seems it can't be merged by itself. @jvff is this correct? |
|
Ah sorry, I just saw @teor2345 's comment 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is part of the update to use Tokio version 1 (#2200), and must be merged together with the other PRs.
On newer versions of Tokio the
broadcast::Receiverdoesn't implementStream, so theStreamExt::nextmethod used intower-batchis no longer available.Solution
Instead of wrapping the
broadcast::Receiverin atokio_stream::wrappers::BroadcastStreamlike in #2922, in this case a simpler solution was used, simply replacing the usage ofStreamExt::next()withbroadcast::Receiver::recv().Review
Anyone from the team can review this, but it shouldn't be merged yet.
Reviewer Checklist
Follow Up Work