Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cache v10 #2644

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Update to cache v10 #2644

merged 2 commits into from
Aug 19, 2021

Conversation

conradoplg
Copy link
Collaborator

@conradoplg conradoplg commented Aug 19, 2021

Motivation

#2599 changes the database version to 10.

Specifications

Designs

Solution

This updates test.yml to use a cache generated with that version.

Review

I've started a run with the value-pools-database branch that contains both #2599 and this PR cherry-picked, to see if it works beforehand https://github.com/ZcashFoundation/zebra/actions/runs/1147067869

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

@conradoplg conradoplg enabled auto-merge (squash) August 19, 2021 17:10
@conradoplg conradoplg merged commit f6416ff into main Aug 19, 2021
@conradoplg conradoplg deleted the update-cache-10 branch August 19, 2021 17:33
@@ -54,7 +54,7 @@ jobs:
--container-image rust:buster \
--container-mount-disk mount-path='/mainnet',name="zebrad-cache-$SHORT_SHA-mainnet-canopy" \
--container-restart-policy never \
--create-disk name="zebrad-cache-$SHORT_SHA-mainnet-canopy",image=zebrad-cache-9121ae2-mainnet-canopy \
--create-disk name="zebrad-cache-$SHORT_SHA-mainnet-canopy",image=zebrad-cache-0fafd6af-mainnet-canopy \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dconnolly dconnolly added this to the 2021 Sprint 16 milestone Aug 19, 2021
@dconnolly
Copy link
Contributor

Well done! ☁️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants