-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memo type, existing EncryptedCiphertext types for Sprout and Sapling #249
Conversation
Co-Authored-By: Henry de Valence <hdevalence@hdevalence.ca>
…t note will be encrypted
This is great! A few comments:
Non-blocking for this PR, looking at the part of the protocol spec you linked, there's a section about memo encodings at the top of page 73 that has four cases: I wonder whether it makes sense to represent this in the enum Memo {
// encoded as 0xf6 0x00 ... 0x00
NoMemo,
// valid UTF-8, encoded with trailing 0x00 padding
Utf8(String),
// encoded as 0xf5 <data>
Bytes(Box<[u8; 511]>),
// everything else we can't parse + reserved
Other(Box<[u8; 512]>),
} and handle the parsing in the serialization implementations. This has the upside that users of the |
Hmm, actually.... I wonder whether the |
This is a nice isolated chunk that can get merged in first.