Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update panics by todo! and unimplemented! macros #2471

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Update panics by todo! and unimplemented! macros #2471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
060dd0b
Add panic message to `unimplemented!`
jvff Jul 8, 2021
779766b
Add panic message that references a tracking issue
jvff Jul 8, 2021
7e6d8bb
Remove incomplete and currently unnecessary code
jvff Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zebra-chain/src/orchard/note/nullifiers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ use super::super::{
/// [poseidonhash]: https://zips.z.cash/protocol/nu5.pdf#poseidonhash
fn poseidon_hash(_x: pallas::Base, _y: pallas::Base) -> pallas::Base {
// TODO: implement: #2064
unimplemented!()
unimplemented!("PoseidonHash is not yet implemented (#2064)")
}

/// Used as part of deriving the _nullifier_ for a Orchard _note_.
Expand Down
11 changes: 1 addition & 10 deletions zebra-consensus/src/transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,26 +43,17 @@ mod tests;
pub struct Verifier<ZS> {
network: Network,
script_verifier: script::Verifier<ZS>,
// spend_verifier: groth16::Verifier,
// output_verifier: groth16::Verifier,
// joinsplit_verifier: groth16::Verifier,
}

impl<ZS> Verifier<ZS>
where
ZS: Service<zs::Request, Response = zs::Response, Error = BoxError> + Send + Clone + 'static,
ZS::Future: Send + 'static,
{
// XXX: how should this struct be constructed?
pub fn new(network: Network, script_verifier: script::Verifier<ZS>) -> Self {
// let (spend_verifier, output_verifier, joinsplit_verifier) = todo!();

Self {
network,
script_verifier,
// spend_verifier,
// output_verifier,
// joinsplit_verifier,
}
}
}
Expand Down Expand Up @@ -153,7 +144,7 @@ where
};
if is_mempool {
// XXX determine exactly which rules apply to mempool transactions
unimplemented!();
unimplemented!("Zebra does not yet have a mempool (#2309)");
}

let script_verifier = self.script_verifier.clone();
Expand Down