Security: do version checks first, then send a verack response #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
025cf34 to
0e41205
Compare
3 tasks
0d424c0 to
50d72a6
Compare
3494e9b to
32616ec
Compare
50d72a6 to
993cc21
Compare
32616ec to
315a32b
Compare
|
Marking as draft until #2120 merges |
We should do as many local checks as possible, before sending further messages.
315a32b to
66abfbe
Compare
dconnolly
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As a general rule, Zebra should do local checks first, then send messages to the peer.
This minor security issue was discovered during #2120, but it's not related to that fix. (It just changes nearby code.)
Review
This is a routine security fix. Anyone can review.
Related Issues
This fix is based on #2120. GitHub will automatically rebase it to main once #2120 merges.