Refactor and document correctness for std::sync::Mutex<AddressBook> #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @oxarbitrage can you review this PR soon? It's blocking #2035. |
teor2345
commented
Apr 20, 2021
Comment on lines
+243
to
+244
| let peers = address_book.lock().unwrap().clone(); | ||
| let mut peers = peers.sanitized(); |
There was a problem hiding this comment.
@fanatid our external address should be added to the cloned peers before they are sanitized().
dconnolly
reviewed
Apr 21, 2021
Comment on lines
195
to
+196
| // TODO: reduce mutex contention by moving the filtering into | ||
| // the address book itself | ||
| // the address book itself (#1976) |
dconnolly
reviewed
Apr 21, 2021
Comment on lines
+259
to
+260
| // In this critical section, we hold the address mutex, blocking the | ||
| // current thread, and all async tasks scheduled on that thread. |
dconnolly
reviewed
Apr 21, 2021
Comment on lines
+387
to
+388
| // TODO: replace with a watch channel that is updated in `AddressBook::update_metrics()`, | ||
| // or turn the address book into a service (#1976) |
dconnolly
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The shared peer address book uses a threaded mutex. So when we're waiting for the lock in async code, we need to be careful to avoid blocking all the tasks on that thread for too long.
Solution
The code in this pull request has:
Review
@oxarbitrage can review once I've tested it locally.
Related Issues
Implements part of #1995
Follow Up Work
The address book and candidate set code is really complex. It would be easier to avoid hang bugs if they were rewritten as services (#1976).