Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the crawl interval and acceptance test timeout #1878

Merged
merged 3 commits into from
Mar 10, 2021
Merged

Adjust the crawl interval and acceptance test timeout #1878

merged 3 commits into from
Mar 10, 2021

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 9, 2021

Motivation

Occasionally, an acceptance test fails because it gets bad peers.

For example, restart_stop_at_height was really slow in PR #1877, but it was still making progress:
https://github.com/ZcashFoundation/zebra/runs/2071085335

Solution

  • Increase the short acceptance test timeout to 120 seconds (was 30 seconds)
  • Make sure Zebra crawls for new peers multiple times within the short test timeout, by making the crawl interval 30 seconds (default 60 seconds)

Review

@oxarbitrage has done a lot of work on these tests. This review isn't urgent.

Related Issues

Fixes an unrelated CI failure in #1877

@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code P-Medium I-integration-fail Continuous integration fails, including build and test failures labels Mar 9, 2021
@teor2345 teor2345 requested a review from oxarbitrage March 9, 2021 23:19
@teor2345 teor2345 self-assigned this Mar 9, 2021
@teor2345 teor2345 mentioned this pull request Mar 9, 2021
Merged
teor2345
teor2345 commented Mar 10, 2021
View reviewed changes
teor2345
teor2345 commented Mar 10, 2021
View reviewed changes
@dconnolly dconnolly added this to the 2021 Sprint 5 milestone Mar 10, 2021
oxarbitrage
oxarbitrage approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks.

@teor2345 teor2345 merged commit 475deaf into main Mar 10, 2021
@teor2345 teor2345 deleted the longer-acceptance-timeout branch March 10, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@teor2345 teor2345

Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Milestone
2021 Sprint 5
Development

Successfully merging this pull request may close these issues.
3 participants
@teor2345 @dconnolly @oxarbitrage