Incomplete: Wake waiting tower-batch clones on close #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When other tower-batch tasks drop, wake any tasks that are waiting for a semaphore permit. Otherwise, tower-batch can hang. We currently pin tower in our workspace to: d4d1c67 hedge: use auto-resizing histograms (tower-rs/tower#484) Copy tower/src/semaphore.rs from that commit, to pick up tower-rs/tower#480.
dconnolly
approved these changes
Feb 17, 2021
18 tasks
|
This fix was incomplete, for details see: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
tower-rs/tower#480 fixes tower's semaphore, to avoid a hang when clones are waiting on another dropped clone. The fix wakes waiting clones when another clone is dropped.
We should apply the same fix to
tower-batch, which has a copy of tower's semaphore impl.Solution
semaphore.rsfrom our pinned version oftowertotower-batchSyncbound on the semaphore's futureReview
We don't know if this hang is happening in practice, so this isn't urgent.
Related Issues
Closes #1671.
Follow Up Work
When we upgrade to tokio 1.0, we can use
tokio_util::PollSemaphore, rather than copying this code fromtower.