Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange zebra-network submodules. #119

Merged
merged 2 commits into from
Nov 27, 2019
Merged

Rearrange zebra-network submodules. #119

merged 2 commits into from
Nov 27, 2019

Conversation

hdevalence
Copy link
Contributor

This has two commits, both of which do git mv + fixup import paths:

  1. Refactor protocol to have equal internal and external modules.
  2. Moves the PeerSet initialization into a submodule.

This is progress on #37, but it doesn't address the item renaming #37 (comment) because I ran out of time. However, that renaming is much less likely to conflict with work like #118, so it can be done later.

Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🦃

@dconnolly dconnolly merged commit 4fbc827 into main Nov 27, 2019
@dconnolly dconnolly deleted the clean-module-layouts branch November 27, 2019 10:06
skyl added a commit to skyl/zebra that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants