Calculate and validate founders reward addresses #1170
Conversation
This comment has been minimized.
This comment has been minimized.
560845f to
91434a9
Compare
| if height >= blossom_height { | ||
| adjusted_height = Height( | ||
| blossom_height.0 | ||
| + ((height.0 - blossom_height.0) / (BLOSSOM_POW_TARGET_SPACING_RATIO as u32)), | ||
| ); | ||
| } |
There was a problem hiding this comment.
It feels like we do post-blossom height adjustments in a few different parts of the code.
Is there a way to abstract them into a new function?
There was a problem hiding this comment.
I created a follow up ticket for this: #1311
This comment has been minimized.
This comment has been minimized.
5bd294d to
0cb4a0e
Compare
Co-authored-by: teor <teor@riseup.net>
d2f6bc6 to
6c62321
Compare
|
I synchronized the |
| if matching_values != matching_address { | ||
| return Err(SubsidyError::FoundersRewardDifferentOutput)?; | ||
| } |
There was a problem hiding this comment.
This needs to be a set intersection test, not an equality test.
It is ok to:
- send the correct value to a different address
- send other values to the correct address
- send multiple correct values to the correct address
As long as at least one correct value is sent to the correct address.
Please also add tests for all these cases.
As an alternative, we could checkpoint on Canopy, and delete this code. (But we'll probably want to re-use this code in the Funding Streams implementation, so we might as well fix it now.)
This PR isn't a high priority, because we're going to checkpoint on Canopy, so we won't need to validate the founders reward. We also need to be sure that this PR is correct before we merge it, and we're still finding bugs. |
|
Since we're checkpointing on Canopy, we can ignore Founders Reward validation. So this ticket is a low priority. |
|
We decided to close this draft PR, and re-open it when we start working on ticket #338 again. |
TODO
See #338
Motivation
Part of the bock subsidy. We merged the validation of founders reward amounts and general block subsidy framework at #1051 and we have a RFC for the whole process being written at #1129.
This PR deals with the founder reward addresses that should be present in the coinbase outputs that must match a calculated address according to current height.
founders_reward_address()and tested attest_founders_address().find_output_with_address()will look into the outputs trying to get the address. Test atsubsidy_is_valid_test().Problem: Calculated address are transparent address while what we have inside outputs is P2SH scripts. We need to decode(or whatever is the right word here) the script to get an address.ResolvedThis is a draft PR and currently need lot of adjustments but it is posted to get help with the above problem. Still, i will probably continue on top of it so feel free to make comments/suggestions for any part of it.