Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Add and Sub for Height #1057

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Implement Add and Sub for Height #1057

merged 2 commits into from
Sep 17, 2020

Conversation

oxarbitrage
Copy link
Contributor

Attempt to close #1055

hdevalence
hdevalence suggested changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start! I think it will be good to go once the u32s are changed to i32s.

hdevalence
hdevalence approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hdevalence hdevalence merged commit 5fbb074 into ZcashFoundation:main Sep 17, 2020
@oxarbitrage oxarbitrage mentioned this pull request Sep 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdevalence hdevalence hdevalence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impl Add, Sub for block::Height
2 participants
@oxarbitrage @hdevalence