Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback NU5 testnet 1, and set consensus parameters for testnet 2 #3018

Closed
teor2345 opened this issue Nov 4, 2021 · 3 comments · Fixed by #3799
Closed

Rollback NU5 testnet 1, and set consensus parameters for testnet 2 #3018

teor2345 opened this issue Nov 4, 2021 · 3 comments · Fixed by #3799
Assignees
Labels
A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks S-blocked Status: Blocked on other tasks

Comments

@teor2345
Copy link
Contributor

teor2345 commented Nov 4, 2021

Motivation

As part of the zcashd mainnet support release, their developers want to change the Orchard circuit on both mainnet and testnet. So we need to rollback testnet to before NU5 activation.

Specifications

https://zips.z.cash/zip-0252

Tasks

Consensus parameters:

  • change the NU5 testnet consensus branch ID
  • change the NU5 testnet activation height

Zebra-specific:

Zebra-specific test changes:

  • update NU5 and Orchard tests, if needed, including:
    • NU5 block test vectors from the first testnet activation
    • NU5 Orchard shielded data test vectors from the first testnet activation
    • any other tests that fail
@teor2345 teor2345 added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Nov 4, 2021
@teor2345 teor2345 added this to the 2021 Sprint 23 milestone Nov 4, 2021
@teor2345 teor2345 added A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes NU-5 Network Upgrade: NU5 specific tasks P-Medium labels Nov 4, 2021
@conradoplg
Copy link
Collaborator

Note that the ZIP-221 history tree, which is stored in state, commits to the consensus branch ID: https://zips.z.cash/zip-0221#tree-node-specification

I guess we'd need to regenerate the state anyway for the rollback, but maybe that warrants also bumping the database version?

@teor2345
Copy link
Contributor Author

teor2345 commented Nov 4, 2021

Note that the ZIP-221 history tree, which is stored in state, commits to the consensus branch ID: https://zips.z.cash/zip-0221#tree-node-specification

I guess we'd need to regenerate the state anyway for the rollback, but maybe that warrants also bumping the database version?

I'll update this part of the ticket to say "database version":

do a testnet rollback by incrementing Zebra's state version

Every v5 transaction also commits to the consensus branch ID.

@mpguerra mpguerra added S-blocked Status: Blocked on other tasks and removed S-needs-triage Status: A bug report needs triage labels Nov 23, 2021
@teor2345 teor2345 changed the title Rollback NU5 testnet and set new consensus parameters Rollback NU5 testnet 1, and set consensus parameters for testnet 2 Feb 2, 2022
@teor2345
Copy link
Contributor Author

I just added "zebra-specific test changes" to this ticket, because the testnet fixes will break some test vectors from the first NU5 testnet activation.

Other tests might also have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks S-blocked Status: Blocked on other tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants