Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to NU5 testnet 2 versions of librustzcash, zcash_script, orchard, halo2_proofs #2982

Closed
teor2345 opened this issue Oct 31, 2021 · 1 comment · Fixed by #3799
Closed
Labels
A-consensus Area: Consensus rule updates A-dependencies Area: Dependency file updates C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks S-blocked Status: Blocked on other tasks

Comments

@teor2345
Copy link
Contributor

teor2345 commented Oct 31, 2021

Motivation

Currently, Zebra and zcash_script depend on a git version of the following shared Zcash crates:

  • zcash_history
  • zcash_primitives
  • zcash_note_encryption
  • orchard
  • incrementalmerkletree
  • equihash
  • zcash_script

And we depend on pre-NU5 versions of:

  • halo2

We need to update to the NU5 testnet 2 versions of these crates.

Tasks

  1. Wait until the zcashd team releases 4.7.0, with the NU5 testnet 2 versions of librustzcash and orchard

halo2_proofs

Try:

halo2 = { package = "halo2_proofs", version = "=0.1.0-beta.2" }

"and then you only need to focus on the API changes, not renaming the imports everywhere."

See also the changelog for `halo2_proofs 0.1.0-beta.2 for all of the API changes relevant to this upgrade.

(This was a separate ticket before, for reference: #3600)

librustzcash

If zcash/librustzcash#459 got merged:
2. In the next steps, update zcash_script and Zebra to the latest git commit of zcash/librustzcash/master

If zcash/librustzcash#459 is still open:
2. Merge zcash/librustzcash/master into ZcashFoundation/librustzcash/download-sprout-params
3. Tag ZcashFoundation/librustzcash/download-sprout-params as a beta release, so zcash_script and Zebra can depend on it

zcash_script

  1. Upgrade zcash_script to the NU5 testnet 2 orchard and librustzcash, removing the git versions in Cargo.toml
  2. Revert module structure changes if needed: Revert zcashd Orchard module structure changes zcash_script#27
  3. Remove the git patches in zcash_script/Cargo.toml
  4. Merge the upgrade and module structure PRs to zcash_script/master
  5. Tag a zcash_script beta release

Zebra

  1. Upgrade Zebra to the NU5 testnet 2 orchard and librustzcash, removing the git versions in Cargo.toml
  2. Upgrade Zebra to the latest version ofzcash_script (git tag)
  3. Remove the exceptions for orchard, librustzcash, and dependencies in deny.toml
  4. Merge the Zebra upgrade PR along with the PR for ticket Rollback NU5 testnet 1, and set consensus parameters for testnet 2 #3018
@teor2345 teor2345 added A-dependencies Area: Dependency file updates C-cleanup Category: This is a cleanup S-needs-triage Status: A bug report needs triage NU-5 Network Upgrade: NU5 specific tasks P-Medium labels Oct 31, 2021
@teor2345 teor2345 added this to the 2021 Sprint 23 milestone Oct 31, 2021
@teor2345 teor2345 added C-enhancement Category: This is an improvement and removed C-cleanup Category: This is a cleanup labels Oct 31, 2021
@teor2345 teor2345 changed the title Upgrade to tagged versions of librustzcash and orchard Upgrade to NU5 mainnet versions of librustzcash and orchard Nov 1, 2021
@mpguerra
Copy link
Contributor

mpguerra commented Nov 3, 2021

@teor2345 teor2345 changed the title Upgrade to NU5 mainnet versions of librustzcash and orchard Upgrade to NU5 testnet 2 versions of librustzcash and orchard Jan 26, 2022
@teor2345 teor2345 changed the title Upgrade to NU5 testnet 2 versions of librustzcash and orchard Upgrade to NU5 testnet 2 versions of librustzcash, orchard Jan 26, 2022
@teor2345 teor2345 changed the title Upgrade to NU5 testnet 2 versions of librustzcash, orchard Upgrade to NU5 testnet 2 versions of librustzcash, zcash_script, orchard Jan 26, 2022
@teor2345 teor2345 added the A-consensus Area: Consensus rule updates label Jan 26, 2022
@teor2345 teor2345 changed the title Upgrade to NU5 testnet 2 versions of librustzcash, zcash_script, orchard Upgrade to NU5 testnet 2 versions of librustzcash, zcash_script, orchard, halo2_proofs Feb 23, 2022
This was referenced Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-dependencies Area: Dependency file updates C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks S-blocked Status: Blocked on other tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants