Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Marek <mail@marek.onl>
  • Loading branch information
gustavovalverde and upbqdn authored Feb 1, 2024
1 parent 7199ada commit 8d8c394
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions docker/.env
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ LOG_COLOR=true
# Check the entrypoint.sh script for more details
###

# Path and name of the config file. These two have defaults set in the Dockerfile.
# The config file full path used in the Dockerfile.
ZEBRA_CONF_PATH=/etc/zebrad/zebrad.toml
# [network]
NETWORK=Mainnet
Expand All @@ -24,7 +24,6 @@ LIGHTWALLETD_DATA_DIR=/var/cache/lwd-cache
METRICS_ENDPOINT_ADDR=0.0.0.0
METRICS_ENDPOINT_PORT=9999
# [tracing]
LOG_COLOR=false
TRACING_ENDPOINT_ADDR=0.0.0.0
TRACING_ENDPOINT_PORT=3000
# [rpc]
Expand Down
4 changes: 2 additions & 2 deletions docker/docker-compose.lwd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ version: "3.8"
services:
zebra:
ports:
- "8232:8232" # Opens an RPC endpoint (for wallet storing and mining)
- "8232:8232" # Opens an RPC endpoint (for lightwalletd and mining)
healthcheck:
start_period: 1m
interval: 15s
timeout: 10s
retries: 3
test: ["CMD-SHELL", "curl --data-binary '{\"jsonrpc\": \"1.0\", \"id\":\"curltest\", \"method\": \"getinfo\", \"params\": [] }' -H 'content-type: application/json' http://127.0.0.1:8232/ || exit 1"]
test: ["CMD-SHELL", "curl --data-binary '{\"id\":\"curltest\", \"method\": \"getinfo\"}' -H 'content-type: application/json' 127.0.0.1:8232 || exit 1"]

lightwalletd:
image: electriccoinco/lightwalletd
Expand Down
4 changes: 2 additions & 2 deletions docker/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ services:
memory: 16G
env_file:
- .env
#! Uncomment the following line to use a zebrad.toml from the host machine
#! Uncomment the `configs` mapping below to use the `zebrad.toml` config file from the host machine
#! NOTE: This will override the zebrad.toml in the image and make some variables irrelevant
# configs:
# - source: zebra_config
Expand All @@ -27,7 +27,7 @@ services:
volumes:
- zebrad-cache:/var/cache/zebrad-cache
ports:
# Zebra uses the following inbound and outbound TCP ports
# Zebra uses the following default inbound and outbound TCP ports
- "8233:8233" # Mainnet Network (for peer connections)
# - "8232:8232" # Opens an RPC endpoint (for wallet storing and mining)
# - "18233:18233" # Testnet Network
Expand Down

0 comments on commit 8d8c394

Please sign in to comment.