Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jubjub requirement from 0.7 to 0.8 #131

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 3, 2021

Updates the requirements on jubjub to permit the latest version.

Changelog

Sourced from jubjub's changelog.

0.8.0

Added

  • jubjub::Base, as an alias for jubjub::Fq.
  • jubjub::AffinePoint::batch_from_bytes, which enables the inversion inside jubjub::AffinePoint::from_bytes to be batched.

Changed

  • Bumped dependencies to bls12_381 0.6, ff 0.11, group 0.11.

0.7.0

Security

  • A bug in the jubjub::{AffinePoint, ExtendedPoint, SubgroupPoint}::from_bytes APIs (and their group::GroupEncoding implementations) has been fixed. The APIs were documented as rejecting non-canonical points, but were accidentally accepting two specific non-canonical encodings. This could potentially cause a problem in consensus-critical protocols that expect encodings to be round-trip compatible (i.e. AffinePoint::from_bytes(b).unwrap().to_bytes() == b). See ZIP 216 for more details.
    • A new API jubjub::AffinePoint::from_bytes_pre_zip216_compatibility preserves the previous behaviour, for use where consensus compatibility is required.

Changed

  • Bumped dependencies to bitvec 0.22, bls12_381 0.5, ff 0.10, group 0.10.
  • MSRV is now 1.51.0.

0.6.0

Changed

  • Bumped dependencies to bitvec 0.20, bls12_381 0.4, ff 0.9, group 0.9, rand_core 0.6.
  • MSRV is now 1.47.0.

0.5.1

Fixed

  • The crate now compiles for non-64-bit targets, such as the wasm32-* targets.

0.5.0

This upgrade bumps our dependencies bls12_381, group and ff, while making corresponding changes to the APIs. This release now only supports Rust compilers version 1.44.0 or later.

0.4.0

This release adds implementations of the ff and group traits. Additional trait implementations (for standard traits) have been added where the ff and group trait bounds require them.

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [jubjub](https://github.com/zkcrypto/jubjub) to permit the latest version.
- [Release notes](https://github.com/zkcrypto/jubjub/releases)
- [Changelog](https://github.com/zkcrypto/jubjub/blob/main/RELEASES.md)
- [Commits](https://github.com/zkcrypto/jubjub/commits/0.8.0)

---
updated-dependencies:
- dependency-name: jubjub
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Sep 3, 2021
@dependabot dependabot bot requested a review from dconnolly September 3, 2021 04:01
@str4d str4d mentioned this pull request Sep 16, 2021
@str4d str4d mentioned this pull request Nov 18, 2021
8 tasks
@conradoplg
Copy link
Contributor

@dependabot recreate

Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this was also the last dependency of Zebra that uses jubjub 0.7. (Though see ZcashFoundation/zebra#2549 before updating Zebra to use the updated redjubjub)

@conradoplg conradoplg merged commit 2f240d8 into main Nov 18, 2021
@conradoplg conradoplg deleted the dependabot/cargo/jubjub-0.8 branch November 18, 2021 18:24
@conradoplg conradoplg restored the dependabot/cargo/jubjub-0.8 branch November 18, 2021 18:49
@conradoplg conradoplg deleted the dependabot/cargo/jubjub-0.8 branch November 18, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants