Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jubjub 0.7 #117

Merged
merged 1 commit into from
Jun 18, 2021
Merged

jubjub 0.7 #117

merged 1 commit into from
Jun 18, 2021

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Jun 3, 2021

No description provided.

@str4d str4d mentioned this pull request Jun 3, 2021
Closed
@dconnolly dconnolly self-assigned this Jun 4, 2021
@dconnolly dconnolly added the dependencies Pull requests that update a dependency file label Jun 4, 2021
oxarbitrage
oxarbitrage approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why not :)

@str4d
Copy link
Contributor Author

str4d commented Jun 4, 2021

This PR is necessary for ZIP 216 consensus compatibility post-NU5. It does not provide pre-NU5 consensus compatibility, but hopefully that's not something zebrad will need to worry about (and if it were, zebrad could depend on two versions).

@conradoplg conradoplg mentioned this pull request Jun 18, 2021
Closed
@conradoplg
Copy link
Contributor

We need this for Zebra, and I have indirectly test this already (compilation-wise) by locally pointing Zebra to use this. Any objections in merging it?

@dconnolly
Copy link
Contributor

We need this for Zebra, and I have indirectly test this already (compilation-wise) by locally pointing Zebra to use this. Any objections in merging it?

Great! I'll merge

@dconnolly dconnolly merged commit f772176 into ZcashFoundation:main Jun 18, 2021
@dconnolly dconnolly added the rust Pull requests that update Rust code label Jun 18, 2021
@str4d str4d deleted the jubjub-0.7 branch June 18, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@dconnolly dconnolly

Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@str4d @conradoplg @dconnolly @oxarbitrage