Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pasta_curves 0.3, blake2b_simd 1 #10

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Migrate to pasta_curves 0.3, blake2b_simd 1 #10

merged 3 commits into from
Jan 19, 2022

Conversation

str4d
Copy link
Collaborator

@str4d str4d commented Jan 18, 2022

Also removes the unused digest dependency.

Also removes the unused digest dependency.
@str4d str4d requested a review from dconnolly January 18, 2022 12:50
src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK modulo the external_doc failure.

@krnak
Copy link
Contributor

krnak commented Jan 19, 2022

Hello, I made some changes to add no-std support for this crate. May you check and merge #11 before releasing version 0.2?

@codecov-commenter
Copy link

Codecov Report

Merging #10 (95c0527) into main (093087e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files          15       15           
  Lines        1148     1148           
=======================================
  Hits          996      996           
  Misses        152      152           

Copy link
Collaborator

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dconnolly dconnolly merged commit cadc865 into main Jan 19, 2022
@dconnolly dconnolly deleted the update-deps branch January 19, 2022 22:54
@dconnolly
Copy link
Collaborator

Hello, I made some changes to add no-std support for this crate. May you check and merge #11 before releasing version 0.2?

I have changes to suggest for the (much larger) no_std PR, that can go out as 0.3 or 0.2.1 or something

@str4d
Copy link
Collaborator Author

str4d commented Jan 20, 2022

Yeah, the no-std changes will be backwards-compatible as long as std remains enabled by default, so can easily be an 0.2.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants