Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PES-2321: sniffer rules update #638

Merged
merged 23 commits into from
Nov 8, 2024
Merged

PES-2321: sniffer rules update #638

merged 23 commits into from
Nov 8, 2024

Conversation

jan-potuznik-z
Copy link
Contributor

No description provided.

@jan-potuznik-z jan-potuznik-z force-pushed the PES-2321-sniffer-rules-update branch from 1a51977 to b5fa988 Compare November 4, 2024 12:02
@Karpec
Copy link
Member

Karpec commented Nov 4, 2024

Nice

@Karpec
Copy link
Member

Karpec commented Nov 4, 2024 •
edited
Loading

  1. btw. je teď zajištěno, že pravidla phpcbf = phpcs?

  2. ten rulset name už nesedí

  3. v testech to nic nenašlo? Nad nima by se to mělo pouštět ale taky ne? Tam je jen excludnutá php compatibilita, že?

@Karpec Karpec self-requested a review November 4, 2024 17:12
@jan-potuznik-z
Copy link
Contributor Author

jan-potuznik-z commented Nov 4, 2024 •
edited
Loading

  1. btw. je teď zajištěno, že pravidla phpcbf = phpcs?

    1. ten rulset name už nesedí

    2. v testech to nic nenašlo? Nad nima by se to mělo pouštět ale taky ne? Tam je jen excludnutá php compatibilita, že?

  1. myslím, že to není jednoduše možné. Lze to ale kontrolovat v pipeline - pokud provede phpcbf změny, tak fail - připraveno.
  2. upraveno
  3. nad testy se to nespouští, viz <file> tagy

@jan-potuznik-z jan-potuznik-z force-pushed the PES-2321-sniffer-rules-update branch 3 times, most recently from 3cedff0 to 129d97e Compare November 4, 2024 18:47
@Karpec
Copy link
Member

Karpec commented Nov 5, 2024 •
edited
Loading

Za mě bych to pouštěl i nad testy, ať je to konzistentní. Nebo je nějaký důvod proč to tam nechceme?

EDIT: vyřešeno

mzk
mzk reviewed Nov 8, 2024
View reviewed changes
@jan-potuznik-z jan-potuznik-z force-pushed the PES-2321-sniffer-rules-update branch from cf75e70 to 35e3a33 Compare November 8, 2024 12:24
@zemekoule zemekoule merged commit 2d5e500 into after-freeze Nov 8, 2024
6 checks passed
@zemekoule zemekoule deleted the PES-2321-sniffer-rules-update branch November 8, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzk mzk mzk approved these changes

@Karpec Karpec Karpec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jan-potuznik-z @Karpec @mzk @zemekoule