Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd-247): incorrect output on toggle #1128

Merged
merged 3 commits into from
Jul 1, 2024
Merged

fix(cmd-247): incorrect output on toggle #1128

merged 3 commits into from
Jul 1, 2024

Conversation

xayanide
Copy link
Member

@xayanide xayanide commented Apr 12, 2024 •
edited
Loading

Thank you for your interest in contributing!

Before proceeding, please review the guidelines for contributing.

  • Are you targeting the next branch? (left side)
  • Did you review the guidelines for contributing?
  • Does your code pass linting checks?
  • Is your code documented, if applicable? (Check if not applicable)
  • Does this PR have a linked issue?

Scope of change

  • Major change
  • Minor change
  • Documentation only

Type of change

  • Bug fix
  • Feature
  • Other

Priority

  • Critical
  • High
  • Medium
  • Low

Description

Please describe the changes.
Context here @ the 24/7 command diff bca6c53

Made the ternary conditional statement as a constant:

            enabled !== null
                ? enabled
                : !(await data.guild.get(
                      interaction.guildId,
                      'settings.stay.enabled',
                  ))

To be reused for condition statements at EmbedBuilder#setDescription, EmbledBuilder#setFooter and the last condition statement that checks if 247 is enabled while nothing is playing.
Closes #1125

@xayanide xayanide added type:bug Issues and PRs: Related to a bug priority:p3 Issues and PRs: Low priority pr:type:fix PRs: Fix status:tested PRs: Tested and working with no issues status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added labels Apr 12, 2024
@xayanide xayanide self-assigned this Apr 12, 2024
@xayanide xayanide requested a review from a team as a code owner April 12, 2024 11:49
@zptx-bot zptx-bot enabled auto-merge (squash) April 12, 2024 11:50
@xayanide xayanide assigned zapteryx and unassigned xayanide Apr 12, 2024
@xayanide xayanide linked an issue Apr 12, 2024 that may be closed by this pull request
24/7 command informing an incorrect status for 24/7 when toggled #1125
Open
2 tasks
auto-merge was automatically disabled July 1, 2024 04:19

Base branch was modified

@zptx-bot zptx-bot enabled auto-merge (squash) July 1, 2024 04:20
@zptx-bot zptx-bot merged commit 5696bb5 into ZPTXDev:next Jul 1, 2024
7 checks passed
zptx-bot pushed a commit that referenced this pull request Jul 1, 2024
@semantic-release-bot
chore(release): 7.0.2-next.3
2d29ef7 
## [7.0.2-next.3](7.0.2-next.2...7.0.2-next.3) (2024-07-01)

### Bug Fixes

* **cmd-247:** incorrect output on toggle ([#1128](#1128)) ([5696bb5](5696bb5))
@zptx-bot
Copy link
Member

zptx-bot commented Jul 1, 2024

🎉 This PR is included in version 7.0.2-next.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

zptx-bot pushed a commit that referenced this pull request Jul 1, 2024
@semantic-release-bot
chore(release): 7.0.2
ddbced0 
## [7.0.2](7.0.1...7.0.2) (2024-07-01)

### Bug Fixes

* **cmd-247:** incorrect output on toggle ([#1128](#1128)) ([5696bb5](5696bb5))
* **music:** rename event names for connect and disconnect ([#1127](#1127)) ([302901b](302901b))
* ts-ignore random stuff ([fdb2d3a](fdb2d3a))
@zptx-bot
Copy link
Member

zptx-bot commented Jul 1, 2024

🎉 This PR is included in version 7.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@xayanide xayanide deleted the next-fix-stay branch March 3, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zapteryx zapteryx zapteryx approved these changes

Assignees

@zapteryx zapteryx

Labels
pr:type:fix PRs: Fix priority:p3 Issues and PRs: Low priority released on @next released status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added status:tested PRs: Tested and working with no issues type:bug Issues and PRs: Related to a bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

24/7 command informing an incorrect status for 24/7 when toggled
3 participants
@xayanide @zptx-bot @zapteryx