fix(lyrics): crash in some circumstances

ZPTXDev · Jul 1, 2024 · d7c7a77 · d7c7a77
1 parent c639d13
commit d7c7a77
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/commands/lyrics.ts b/src/commands/lyrics.ts
@@ -112,7 +112,7 @@ export default {
             romanizeFrom = 'chinese';
         }
         const lyricsFields = generateEmbedFieldsFromLyrics(json, lyrics);
-        if (lyricsFields.length === 0) {
+        if (lyricsFields.length === 0 || !lyricsFields[0].value) {
             await interaction.replyHandler.locale(
                 'CMD.LYRICS.RESPONSE.NO_RESULTS',
                 { type: MessageOptionsBuilderType.Error },

diff --git a/src/components/buttons/lyrics.ts b/src/components/buttons/lyrics.ts
@@ -65,7 +65,7 @@ export default {
                     .join('\n');
         }
         const lyricsFields = generateEmbedFieldsFromLyrics(json, lyrics);
-        if (lyricsFields.length === 0) {
+        if (lyricsFields.length === 0 || !lyricsFields[0].value) {
             await interaction.replyHandler.locale(
                 'CMD.LYRICS.RESPONSE.NO_RESULTS',
                 { type: MessageOptionsBuilderType.Error },

diff --git a/src/events/music/trackStart.ts b/src/events/music/trackStart.ts
@@ -229,7 +229,7 @@ export default {
                 json,
                 lyrics,
             );
-            if (lyricsFields.length === 0) return;
+            if (lyricsFields.length === 0 || !lyricsFields[0].value) return;
             await queue.player.handler.send(
                 new EmbedBuilder().setFields(lyricsFields),
                 {