Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove token since it is persisted automatically now #30

Merged
merged 1 commit into from
Feb 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/create-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
# Invoking workflow has to pass a personal access token with permission to pull/push on the target repo.
token: ${{ secrets.PUSH_TO_GITHUB_REPO_PAT }}

- name: Save NuGet version to a variable for easy access.
run: |
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/create-support-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
token: ${{ secrets.PUSH_TO_GITHUB_REPO_PAT }}

- name: Save NuGet version to a variable for easy access.
run: |
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,5 +85,4 @@ Publish the build artifact (NuGet package) to a target nuget feed.
Two of the workflows require secrets to be passed on to work as intended:

* `publish.yml` pushes NuGet packages to nuget.org and needs a personal access token named `NUGET_FEED_PAT` with proper permissions
* `create-release.yml` creates commits, merges and creates branches and pushes to the target repository and need a GitHub personal access token name `PUSH_TO_GITHUB_REPO_PAT` with proper permissions
- the only permission to be set is `public_repo`
* `create-release.yml` creates commits, merges and creates branches and pushes to the target repository