StartingNotebook #68
Merged
StartingNotebook #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theres a lot of extra adds / removes because the main mm3d_randomizer points to a specific commit and im too dumb to get it to work right. important changes are as follows
Settings.h > Added u8 startingNotebook;
Savefile.cpp > added if statement into starting inventory section
//Notebook
if(gSettingsContext.startingNotebook > 0) {
saveData.inventory.collect_register.bombers_notebook = 1;
}
Spoiler_data.cpp > added two missing multilocation checks for the ranch map in snowhead
PhlexPlexico
requested changes
May 27, 2024
PhlexPlexico
added a commit
that referenced
this pull request
May 28, 2024
This reverts commit 09d5cff.
PhlexPlexico
added a commit
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May want to extra review this as im dumb and couldnt figure out how to point my fork to the commit thats currently being used on mm3d_randomizer, below are what i had added and are needed for the starting with bombers notebook option and spoiler log fixes.
Settings.h > Added following
Savefile.cpp > added if statement into starting inventory section
Spoiler_data.cpp(this whole file is ok actually0 > added two missing multilocation checks for the ranch map in snowhead