Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Allow login by mail #783

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[enh] Allow login by mail #783

merged 1 commit into from
Feb 11, 2025

Conversation

zamentur
Copy link
Contributor

Problem

Related to YunoHost/yunohost#2041

Solution

Allow to login by mail

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Tested on a prod setup by running:

yunohost app shell nextcloud
php ./occ ldap:set-config "" ldapLoginFilter "(&(|(objectclass=posixAccount))(|(uid=%uid)(mail=%uid))(permission=cn=nextcloud.main,ou=permission,dc=yunohost,dc=org))"

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@zamentur zamentur changed the base branch from master to testing February 11, 2025 10:55
Copy link
Member

@ericgaspar ericgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@ericgaspar ericgaspar merged commit 83bb5a6 into testing Feb 11, 2025
@ericgaspar ericgaspar deleted the enh-login-by-mail branch February 11, 2025 13:48
@ericgaspar ericgaspar mentioned this pull request Feb 11, 2025
ericgaspar added a commit that referenced this pull request Feb 13, 2025
* move function to common.sh (#764)

* move function to common.sh

* Update config

* add default_phone_region

* Update nginx.conf

* Update install

* Fix upgrade exploding when $app is nextcloud__2, __3 etc because the virtual apt/dpkg package is named with - and not _ (#767)

* Update upgrade

replace correct file for nextcloud--x-ynh-deps

* Update upgrade

correct syntax for the helpers

* Bump package revision

* Auto-update READMEs

* Patch (#768)

* remove inused patch with YNH 12

* reorder patch

* 30.0.5

* Auto-update READMEs

* Update restore

* Update upgrade (#777)

* Update upgrade

* Update manifest.toml

* Update manifest.toml

* Update post_user_delete (#778)

* Update upgrade (#779)

* [fix] Remove eval JS patch cause yunohost tiles doesn't exists anymore

* Update manifest.toml

* Auto-update READMEs

* cleaning

* cleaning

* Update remove

* [enh] Allow login by mail (#783)

* 30.0.6

* Auto-update READMEs

---------

Co-authored-by: Robles Rodolphe <rodolphe.robles@sfr.fr>
Co-authored-by: yunohost-bot <yunohost@yunohost.org>
Co-authored-by: ljf <ljf+git@grimaud.me>
Co-authored-by: ljf (zamentur) <zamentur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants