Fixed errors which are happening if switch between alert types (elast…

…ic#60453)
YulNaumenko · Mar 18, 2020 · 4e5faa5 · 4e5faa5
1 parent 26352d5
commit 4e5faa5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.tsx
@@ -155,6 +155,7 @@ export const AlertForm = ({ alert, canChangeTrigger = true, dispatch, errors }:
         onClick={() => {
           setAlertProperty('alertTypeId', item.id);
           setAlertTypeModel(item);
+          setAlertProperty('params', {});
           if (alertTypesIndex && alertTypesIndex[item.id]) {
             setDefaultActionGroupId(alertTypesIndex[item.id].defaultActionGroupId);
           }
@@ -194,6 +195,7 @@ export const AlertForm = ({ alert, canChangeTrigger = true, dispatch, errors }:
               onClick={() => {
                 setAlertProperty('alertTypeId', null);
                 setAlertTypeModel(null);
+                setAlertProperty('params', {});
               }}
             />
           </EuiFlexItem>

diff --git a/x-pack/plugins/triggers_actions_ui/public/common/index_controls/index.ts b/x-pack/plugins/triggers_actions_ui/public/common/index_controls/index.ts
@@ -10,6 +10,7 @@ import {
   loadIndexPatterns,
   getMatchingIndicesForThresholdAlertType,
   getThresholdAlertTypeFields,
+  getSavedObjectsClient,
 } from '../lib/index_threshold_api';
 
 export interface IOption {
@@ -18,8 +19,12 @@ export interface IOption {
 }
 
 export const getIndexPatterns = async () => {
-  const indexPatternObjects = await loadIndexPatterns();
-  return indexPatternObjects.map((indexPattern: any) => indexPattern.attributes.title);
+  // TODO: Implement a possibility to retrive index patterns different way to be able to expose this in consumer plugins
+  if (getSavedObjectsClient()) {
+    const indexPatternObjects = await loadIndexPatterns();
+    return indexPatternObjects.map((indexPattern: any) => indexPattern.attributes.title);
+  }
+  return [];
 };
 
 export const getIndexOptions = async (