forked from facebookincubator/velox
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Avoid redownload coalesced region gap twice in buffered inputs
Summary: In the current `DirectBufferedInput` and `CachedBufferedInput`, when we coalesce some regions during prefetch, the gap between regions are not marked as available, and if they are needed in adhoc streams, we would issue separate IOs for them, resulting in unnecessary IOs. This change fixes this by rearranging the regions and loads generation logic, first generate and group the prefetch regions, then we can compare the coalesced regions to the adhoc regions and move those already coalesced to the prefetch loads, reducing the number of adhoc IOs. Differential Revision: D67810195
- Loading branch information
1 parent
8b3b55a
commit 132eaf9
Showing
6 changed files
with
235 additions
and
100 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.