Add Desktop Platform Support for YubiKey SDK #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hid4java API returns lengths that include both the payload and the extra byte for the report ID. This extra byte can essentially be ignored. Right now this extra byte is special cased in our code to run on Windows - we'll need to test on other OSes to see if it is necessary there as well.
dainnilsson
requested changes
Jan 21, 2025
README.adoc
Outdated
| @@ -76,6 +76,16 @@ If you run into any issues during the development process, please fill out a | |||
| developer https://support.yubico.com/support/tickets/new[support ticket] and | |||
| our team will be happy to assist you. | |||
|
|
|||
| === Support for desktop apps | |||
| WARNING: This is an introductory version and is not intended for production use. | |||
There was a problem hiding this comment.
I would call it an "experimental" version rather than "introductory". Also add a line stating that the API should not be considered stable, and may change with new versions.
|
Also add a README.adoc to DesktopDemo/ |
dainnilsson
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR extends the Android YubiKey SDK to support desktop platforms (macOS, Linux, and Windows), enabling developers to build desktop applications that can communicate with YubiKeys using the same SDK.
Current Status⚠️
This is an initial beta implementation with the following limitations:
Key Changes
Testing