Link yubihsm_pkcs11 against static libyubihsm when ENABLE_STATIC is on #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ff0f45 to
7f796ee
Compare
cc23023 to
99bdc43
Compare
dacav
approved these changes
Dec 3, 2024
pkcs11/CMakeLists.txt
Outdated
| ${LIBCRYPTO_LDFLAGS} | ||
| ${GETOPT_LIBS} | ||
| ) | ||
| endif(ENABLE_STATIC) |
There was a problem hiding this comment.
If you wish, I'm quite sure you can have multiple additions, e.g.
target_link_libraries(x a b c)
if (ENABLE_STATIC)
target_link_libraries(x d_static)
else()
target_link_libraries(x d)
endif()
AFAIK the argument of else() and endif() can be (nowadays) omitted.
I don't know much about this project: are some of these dependencies eligible as PRIVATE?
There was a problem hiding this comment.
Thanks for the review, I have updated as you suggested. Not sure what you mean by PRIVATE here
aveenismail
approved these changes
Dec 3, 2024
99bdc43 to
88f164c
Compare
aveenismail
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.