Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes to the PIV documentation based on Ben's feedback #410

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

csalas-yubico
Copy link
Contributor

@beneichorst provided feedback to the developer program on changes to the PIV attestation documentation on the DYC - The changes reflect the changes provided to us

This request is related to the PR open for the DYC: Yubico/developers.yubico.com#513

Copy link
Contributor

@qpernil qpernil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attestation certificate _can_be restored, but of course this is only meaningful if the original key hasn't been overwritten. The reason is that the key and certificate are two separate objects in PIV, and the slot is actually for the key. There is a corresponding certificate data object with it's own id, mapped according to the PIV spec by the tooling, so you never see this id. The certificate could either be saved before being overwritten, or taken from another YubiKey from the same attestation batch (i.e. with the same default attestation key). This technicality doesn't change much, just for accuracy.

Copy link
Contributor

@qpernil qpernil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably worth mentioning that an attestation is in fact an x.509 certificate for that slot, containing the correct public key even if the certificate object for that slot has not been properly provisioned.

Copy link
Contributor

@qpernil qpernil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure, but perhaps the metadata service should be mentioned, as it provides a complementary function - you can use metadata to get information (including the public key) about a key slot for imported keys, for which attestations are not available.

@aveenismail aveenismail merged commit 4da3489 into Yubico:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants