Add timestamps to debug log messages #312
Closed
+18
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `get_timestamp` function to generate current time in a thread-safe manner using `localtime_r`. - Modified `do_log` function to prepend timestamps to each log message. - Defined `TIMELEN` constant for timestamp buffer size. - Timestamp is included in both syslog and file output. - Closes Yubico#311
|
Hi, Considering you should be able to get timestamps through e.g. syslog already and that we haven't seen the use for this very often, we'll be closing this for now. We'll keep it in mind if we need it in the future. Thanks for contributing! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_timestampfunction to generate current time in a thread-safe manner usinglocaltime_r.do_logfunction to prepend timestamps to each log message.TIMELENconstant for timestamp buffer size.