Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting of code blocks #3

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Fix formatting of code blocks #3

merged 3 commits into from
Mar 18, 2024

Conversation

emlun
Copy link
Member

@emlun emlun commented Mar 1, 2024

Looks like the ``` syntax for code blocks isn't supported; use indentation by 4 spaces instead.

@emlun emlun requested a review from ve7jtb March 1, 2024 17:51
@ve7jtb
Copy link
Collaborator

ve7jtb commented Mar 1, 2024

You have made the lines too long. There is a 72 character max line length.
That is why I manually wrapped some of them to prevent them from being cut off or having to horizontally scroll for those blocks.

Remember the official versions are TEXT.

(969) Unused reference: There seems to be no reference to [hkdf] in the document
(1009) Unused reference: There seems to be no reference to [RFC3279] in the document
(333) Artwork too wide, reducing indentation from 3 to 0
(327) Section too wide, reducing indentation from 0 to 0
(359) Artwork too wide, reducing indentation from 3 to 0
(352) Section too wide, reducing indentation from 0 to 0
(401) Artwork too wide, reducing indentation from 3 to 0
(394) Section too wide, reducing indentation from 0 to 0
(142) Section too wide, reducing indentation from 0 to 0
(63) Section too wide, reducing indentation from 0 to 0
(60) Middle too wide, reducing indentation from 0 to 0
(333) Too long line found (L476), 5 characters longer than 72 characters:
(333) Too long line found (L477), 13 characters longer than 72 characters:
(333) Too long line found (L482), 6 characters longer than 72 characters:
(359) Too long line found (L511), 5 characters longer than 72 characters:
(359) Too long line found (L512), 13 characters longer than 72 characters:
(359) Too long line found (L514), 9 characters longer than 72 characters:
(359) Too long line found (L515), 25 characters longer than 72 characters:
(359) Too long line found (L516), 5 characters longer than 72 characters:
(401) Too long line found (L567), 5 characters longer than 72 characters:
(401) Too long line found (L568), 13 characters longer than 72 characters:
(401) Too long line found (L570), 9 characters longer than 72 characters:
(401) Too long line found (L571), 1 characters longer than 72 characters:
(401) Too long line found (L573), 5 characters longer than 72 characters:

@emlun emlun force-pushed the code-block-formatting branch from afeceb9 to 1c53a56 Compare March 5, 2024 13:50
@emlun
Copy link
Member Author

emlun commented Mar 5, 2024

Should be fixed now!

@emlun emlun force-pushed the code-block-formatting branch from ab52419 to 936c743 Compare March 5, 2024 14:58
@emlun emlun force-pushed the main branch 4 times, most recently from 2738c6f to 93a7f8b Compare March 5, 2024 18:47
@emlun emlun force-pushed the code-block-formatting branch from 936c743 to 1e9f86a Compare March 5, 2024 18:52
@emlun emlun force-pushed the code-block-formatting branch from 1e9f86a to 6d5c7df Compare March 5, 2024 18:54
@emlun
Copy link
Member Author

emlun commented Mar 5, 2024

I've now also set up the GitHub Action to host rendered drafts on GitHub Pages: https://yubico.github.io/arkg-rfc/ , including preview and diff views of pull request branches.

@ve7jtb
Copy link
Collaborator

ve7jtb commented Mar 18, 2024

LGTM

@ve7jtb ve7jtb merged commit bba8fae into main Mar 18, 2024
2 checks passed
@ve7jtb ve7jtb deleted the code-block-formatting branch March 18, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants