Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Csv #18

Merged
merged 4 commits into from
Jun 26, 2019
Merged

Csv #18

merged 4 commits into from
Jun 26, 2019

Conversation

YoungFaithful
Copy link
Owner

Adressing #14

@YoungFaithful
Copy link
Owner Author

I didn't check in the newest documentation in the first commit (still had an older CSV version on my local mashine) and it didn't throw any warning, so I thought optional is enough...

holgerteichgraeber
holgerteichgraeber requested changes Jun 25, 2019
View reviewed changes
Copy link
Collaborator

@holgerteichgraeber holgerteichgraeber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in strict

@YoungFaithful
Update load_data.jl
7a486ae 
srict -> strict
@YoungFaithful
Copy link
Owner Author

There is a typo in strict

Oh yeah...

@holgerteichgraeber holgerteichgraeber changed the base branch from dev to master June 26, 2019 17:23
@holgerteichgraeber
Copy link
Collaborator

#19 was to master, so changed branch of this one to master too.

@holgerteichgraeber holgerteichgraeber merged commit d23ffab into master Jun 26, 2019
@YoungFaithful YoungFaithful deleted the CSV branch August 13, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerteichgraeber holgerteichgraeber holgerteichgraeber requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoungFaithful @holgerteichgraeber