Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatability update for ClustForOpt 0.4.0 #16

Merged
merged 3 commits into from
Jun 26, 2019
Merged

Compatability update for ClustForOpt 0.4.0 #16

merged 3 commits into from
Jun 26, 2019

Conversation

holgerteichgraeber
Copy link
Collaborator

  • Updated structs from ClustForOpt
  • Somehow the test case with multiple nodes fails on my personal machine. Can you have a look, I do not know why?

@holgerteichgraeber holgerteichgraeber self-assigned this Jun 8, 2019
@YoungFaithful
Copy link
Owner

The problem is that some values in GER_18 are not met exactly. I'll try to find the reason for that.

@YoungFaithful
Copy link
Owner

YoungFaithful commented Jun 25, 2019 •
edited
Loading

Mir scheint, als wäre das wieder das Zuordnungsproblem in ClustForOpt: wird einfach nur PV an einer Stelle und Trassen ausgebaut...
image

@holgerteichgraeber
Copy link
Collaborator Author

Mir scheint, als wäre das wieder das Zuordnungsproblem in ClustForOpt: wird einfach nur PV an einer Stelle und Trassen ausgebaut...
image

How did we fix that last time, I though we took care of that by use of arrays?
I am surprised because generally all this commit did was change the naming of best_result to clust_data, I don't see a connection there.

@YoungFaithful
Copy link
Owner

I will rerun the tests as soon as bug is merged in ClustForOpt

@holgerteichgraeber
Copy link
Collaborator Author

@YoungFaithful the tests on the 18 node system still fail. Any idea why?

@YoungFaithful
Copy link
Owner

I think we may have to wait until the new version is registered...

@holgerteichgraeber
Copy link
Collaborator Author

Nice, it passed after version 0.4.1 of ClustForOpt was registered.

@holgerteichgraeber holgerteichgraeber merged commit 36d0a4c into dev Jun 26, 2019
@YoungFaithful YoungFaithful deleted the clustresult branch August 13, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoungFaithful YoungFaithful Awaiting requested review from YoungFaithful

Assignees

@holgerteichgraeber holgerteichgraeber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerteichgraeber @YoungFaithful