[Apple's Broken Compression Handling] NSPOSIXError when trying to connect from Damus

[syobocat]

Hello.
When I try to connect to a bouncer from Damus app, it fails with Error: Error Domain=NSPOSIXErrorDomain Code=100 "Protocol error" UserInfo={NSDescription=Protocol error} and Damus attempts to reconnect over and over.

Here is the screenshot:

My bostr2 instance is running with Go 1.21.12 on 14.1-RELEASE-p2, and is behind Caddy and Cloudflare.

[Yonle]

This is strange. Try paste logs printed on the bostr2 server.

[Yonle]

Just checked, The error 100 is referring to failed HTTP/2 connections.

It looks like it's trying to connect with HTTP/2, which is not supported by nhooyr.io/websocket lib yet

[Yonle]

You could try restart bostr2 with GODEBUG=http2server=0 environment variable being set.

[syobocat]

I set GODEBUG=http2server=0 and restarted bostr2, but I still got the same error.

Also, I tried connecting to the server directly (without any reverse proxy), but the result was the same, too.

Here is the log bostr2 printed:

⋮
2024/07/28 22:54:57 172.70.122.72 connected (damus/14 CFNetwork/1496.0.7 Darwin/23.5.0)
2024/07/28 22:54:57 172.70.122.72: failed to get reader: failed to read frame header: EOF
2024/07/28 22:54:57 172.70.122.72 disconnect (damus/14 CFNetwork/1496.0.7 Darwin/23.5.0)
2024/07/28 22:54:59 162.158.118.73 connected (damus/14 CFNetwork/1496.0.7 Darwin/23.5.0)
2024/07/28 22:55:00 162.158.118.73: failed to get reader: failed to read frame header: EOF
2024/07/28 22:55:00 162.158.118.73 disconnect (damus/14 CFNetwork/1496.0.7 Darwin/23.5.0)
2024/07/28 22:55:02 172.68.118.227 connected (damus/14 CFNetwork/1496.0.7 Darwin/23.5.0)
2024/07/28 22:55:02 172.68.118.227: failed to get reader: failed to read frame header: EOF
2024/07/28 22:55:02 172.68.118.227 disconnect (damus/14 CFNetwork/1496.0.7 Darwin/23.5.0)
2024/07/28 22:55:04 172.70.222.139 connected (damus/14 CFNetwork/1496.0.7 Darwin/23.5.0)
⋮

If I try connecting directly, it shows a slightly different message:

⋮
2024/07/28 23:32:16 192.168.0.221:52741 connected (damus/14 CFNetwork/1496.0.7 Darwin/23.5.0)
2024/07/28 23:32:16 192.168.0.221:52741: failed to get reader: received close frame: status = StatusProtocolError and reason = ""
2024/07/28 23:32:16 192.168.0.221:52741 disconnect (damus/14 CFNetwork/1496.0.7 Darwin/23.5.0)
2024/07/28 23:32:18 192.168.0.221:52743 connected (damus/14 CFNetwork/1496.0.7 Darwin/23.5.0)
2024/07/28 23:32:18 192.168.0.221:52743: failed to get reader: received close frame: status = StatusProtocolError and reason = ""
2024/07/28 23:32:18 192.168.0.221:52743 disconnect (damus/14 CFNetwork/1496.0.7 Darwin/23.5.0)
2024/07/28 23:32:19 192.168.0.221:52744 connected (damus/14 CFNetwork/1496.0.7 Darwin/23.5.0)
2024/07/28 23:32:19 192.168.0.221:52744: failed to get reader: received close frame: status = StatusProtocolError and reason = ""
2024/07/28 23:32:19 192.168.0.221:52744 disconnect (damus/14 CFNetwork/1496.0.7 Darwin/23.5.0)
2024/07/28 23:32:21 192.168.0.221:52745 connected (damus/14 CFNetwork/1496.0.7 Darwin/23.5.0)
⋮

[Yonle]

Majority of servers out here are using HTTP/1.1, and they worked most of the time.

I checked the connection, Nothing wrong with header nor status.

Just added an option to stop serving invalid Upgrade header. I have no idea whenever it would made any difference.

Either way, You could test with the recent commit on master. Clone this repository, go install ., try restart and see will it make any difference.

If still persist, and this problem is not able to be reproduced on bostr, Then my final guessing is the problem is on nhooyr's websocket lib.

[Yonle]

Looks like it has something to do with compression.

coder/websocket#218

[Yonle]

Disabled compression due to it being unreliable at very certain cases. Could you try again with the recent commit?

[Yonle]

Added a code that disables compression on apple while keeping it on for others.

Well well well.

Right now, It should've fixed. But not a good fix unfortunately.

[Yonle]

Fixed on v1.0.1

[syobocat]

I tried 1.0.1 and it worked as expected.
Thank you so much!