New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

several bug fixes (retry of #6) #7

Merged

Yonle merged 4 commits into Yonle:master from ryogrid-watch:PR-6-revised

Dec 25, 2023

Contributor

ryogrid commented Dec 25, 2023 •

edited

Loading

I reviewed code of my PR #6 and your mofidification

I think fixes below only are needed.

condition of if statement at line 119 seems to wrong
- original code can't check size of client.pendingEOSE.get(data[1]) collectly
replaced clearInterval to clearTimeout
- canceling function for timer which is created by setTimeout is clearTimeout

ryogrid added 4 commits

December 24, 2023 09:27


          Update README.md

4dfbb1b


          Merge branch 'master' of https://github.com/ryogrid/bostr

3483f82


          added some fix.

15a3ee8


          removed needless modification to README.md

ee65c14

ryogrid changed the title ~~some buf fix (retry of #6)~~ several bug fixes (retry of #6)

Yonle merged commit 99a0768 into Yonle:master

Owner

Yonle commented Dec 25, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet