-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
367 site kit tables UI #21951
367 site kit tables UI #21951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 🏗️
packages/js/tests/dashboard/scores/components/site-kit-table.test.js
Outdated
Show resolved
Hide resolved
48a9840
to
0c89765
Compare
Pull Request Test Coverage Report for Build dd8a089178f4873525ae2f4cf97d728215c35c56Details
💛 - Coveralls |
revert dashboard changes
drop sort drop sorting from tests
0c89765
to
ef5a2ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AT ✅
I'm leaving the merge to you tomorrow, depending on whether you want to sneak in the less padding or not!
Either way, I approve! 😄
P.S. took the liberty to change the UI library changelog (and add enhancement
)
Context
Summary
This PR can be summarized in the following changelog entry:
minimal
variant next to the current being thedefault
.Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Add dummy data and tables to the dashboard by applying this patch table-widget-dummy-data.patch
Go to Yoast SEO-> General
Check the you see the test table
Check the first column values are with weight 500 and color slate-900
Check the SEO score values are rendered with matching bullet colors and screen reader text.
Check the SEO score bullet is centered to the column title.
Storybook
minimal
variant.striped
.Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Available variables
looks the same.UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/reserved-tasks/issues/403