Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline link aria-label fix #15660

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Inline link aria-label fix #15660

merged 1 commit into from
Jul 16, 2020

Conversation

omarreiss
Copy link
Contributor

@omarreiss omarreiss commented Jul 14, 2020

Context

  • Fixes a bug where an inline link that opens in a new window would render undefined in the aria-label

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where an inline link that opens in a new window would render undefined in the aria-label.

Relevant technical choices:

  • Omit the aria-label entirely until Gutenberg comes up with a better solution.

Test instructions

This PR can be tested by following these steps:

  • create a post
  • add a paragraph
  • select some text in the paragraph and add an external link
  • check "Open in new tab" in the add link UI
  • save the post
  • see the post preview
  • inspect the link source and confirm there is no longer an aria label value.

Quality assurance

  • I have tested this code to the best of my abilities

Fixes https://yoast.atlassian.net/browse/P1-71

@omarreiss omarreiss added the changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog label Jul 14, 2020
@omarreiss omarreiss added this to the 14.7 milestone Jul 14, 2020
@igorschoester igorschoester merged commit dbf8a99 into trunk Jul 16, 2020
@igorschoester igorschoester deleted the P1-71-aria-bug branch July 16, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants