Read-write tests #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yikai-Liao
reviewed
Dec 17, 2023
symusic/factory.py
Outdated
| @@ -60,7 +61,7 @@ def __call__(self, ttype: Union[smt.TimeUnit, str]) -> smt.TimeUnit: | |||
| ttype.is_time_unit() | |||
| return ttype | |||
| except AttributeError: | |||
| raise TypeError(f"{ttype} is not a TimeUnit object") | |||
| raise TypeError(f"{ttype} is not a TimeUnit object") from None | |||
There was a problem hiding this comment.
To indicate what's causing the issue, flagged by ruff
I actually just updated it with except AttributeError as e and from e
|
Thank you for the merge, I'm now working on the CI integration, and actually running them :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds MIDI read-write tests, within a dedicated
testsmodule to be used with pytest. (not run yet)The next part is to figure how to run them in GitHub actions, probably after the wheel builds on each platform.
It also adds a
ruff.tomlconfiguration, which is passing right now. Ultimately more rules should be enforced (that would need fixes).